Fix error handling in FastCommit() - Githubissues

onflow / atree

Atree provides scalable arrays and scalable ordered maps.

https://onflow.org

Apache License 2.0

39 stars 16 forks source link

Fix error handling in FastCommit() #241

Closed fxamacker closed 2 years ago

fxamacker commented 2 years ago

Description

Prevent error handling in FastCommit() from closing channel before all goroutines are done.

This PR resolves nondeterministic CI test failure from slower goroutine sending on closed channel after FastCommit() exits early on error detection.

Test case to reproduce the problem uses division in a loop to simulate slow encoding inside a goroutine because using sleep was flaky.

Closes #240

[x] Targeted PR against main branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[x] Code follows the standards mentioned here
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels