onflow / atree

Atree provides scalable arrays and scalable ordered maps.
https://onflow.org
Apache License 2.0
39 stars 16 forks source link

Add regression test for CircleHash64 to detect breaking changes after updates #245

Closed fxamacker closed 2 years ago

fxamacker commented 2 years ago

Issue To Be Solved

Atree does not currently check 3rd party libraries like CircleHash64 for breaking changes.

It is best practice to do this with all 3rd party libraries, especially cryptographic functions and non-cryptographic hashes.

Big thanks to @turbolent for the suggestion to check CircleHash64 during a PR review. 👍

Suggested Solution

Add tests to confirm CircleHash64 produces expected results.

fxamacker/circlehash has a compatibility test suite that checks nearly 600,000 digests. Use a subset of that compatibility test suite in Atree to detect breaking changes.