onflow / atree

Atree provides scalable arrays and scalable ordered maps.
https://onflow.org
Apache License 2.0
39 stars 16 forks source link

Add CI check for vulnerabilities affecting Go code #294

Closed fxamacker closed 1 year ago

fxamacker commented 1 year ago

Description

Add a GitHub Actions workflow to run govulncheck.

According to govulncheck docs:

Govulncheck reports known vulnerabilities that affect Go code. It uses static analysis of source code or a binary's symbol table to narrow down reports to only those that could affect the application.

By default, govulncheck makes requests to the Go vulnerability database at https://vuln.go.dev. Requests to the vulnerability database contain only module paths, not code or other properties of your program.

More info at:

Closes #293


turbolent commented 1 year ago

Good idea, but it might be better to do this in dapperlabs/atree-internal

fxamacker commented 1 year ago

Good idea, but it might be better to do this in dapperlabs/atree-internal

Hey @turbolent that sounds good, @j1010001 made similar comment.

Maybe we can setup a single private repo to govulncheck multiple public repos. Someone in Flow Admins would seem better suited for this task, I'll ask @j1010001.

If we are also moving CodeQL and all similar vulnerability scanning off of public repos, then maybe we can use the same private repo for those too.