Closed fxamacker closed 1 year ago
Merging #316 (044db01) into main (7c97278) will decrease coverage by
0.03%
. The diff coverage is66.66%
.
@@ Coverage Diff @@
## main #316 +/- ##
==========================================
- Coverage 64.62% 64.60% -0.03%
==========================================
Files 14 14
Lines 7991 8000 +9
==========================================
+ Hits 5164 5168 +4
- Misses 2152 2155 +3
- Partials 675 677 +2
Impacted Files | Coverage Δ | |
---|---|---|
array.go | 69.80% <66.66%> (-0.07%) |
:arrow_down: |
Closes #315 Updates #296 #292
Description
This PR changes
Array.Get()
to returnValue
instead ofStorable
.Currently,
Array.Get()
returnsStorable
and client converts returnedStorable
toValue
. However, it only makes sense to returnStorable
if client needs to remove register (slab) byStorageID
(StorageIDStorable).Get()
should only provideValue
without possibility of client manipulating the underlyingStorable
.This is prep work for Atree Register Inlining (#292) and will also harden the API.
main
branchFiles changed
in the Github PR explorer