Resolve issues found during Cadence integration for Atree inlining and deduplication - Githubissues

onflow / atree

Atree provides scalable arrays and scalable ordered maps.

https://onflow.org

Apache License 2.0

39 stars 13 forks source link

Resolve issues found during Cadence integration for Atree inlining and deduplication #351

Closed fxamacker closed 8 months ago

fxamacker commented 8 months ago

I ran into some integration issues while updating onflow/cadence to use Atree PR #342 and #345. We should:

[ ] Rename TypeInfo.ID() to TypeInfo.Identifier()
[ ] Change array encoding error type
[ ] Change map encoding error type
[ ] Add InlinedExtraData interface
[ ] Add ContainerStorable interface
[ ] Rename Encode to EncodeSlab
[ ] Encode inlined map as map key
[ ] Add test verification for compact map serialization
[ ] Add more tests for decoded array/map
[ ] Export EncodeStorableAsElement()
[ ] Add ContainerStorable.HasPointer()

More details will be in the PR that closes this issue.

fxamacker commented 8 months ago

This is closed by #352 and https://github.com/onflow/cadence/pull/2920.

For more info, see https://github.com/onflow/cadence/pull/2882.