onflow / contract-updater

Enabling delayed contract updates to a wrapped account at or beyond a specified block height
The Unlicense
4 stars 9 forks source link

Update StagingStatusUpdated.code event value to SHA3_256 hash #38

Closed sisyphusSmiling closed 1 month ago

sisyphusSmiling commented 1 month ago

Closes: #37


For contributor use:

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.81%. Comparing base (5f45a7f) to head (f165996).

Files Patch % Lines
contracts/MigrationContractStaging.cdc 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #38 +/- ## ========================================== - Coverage 83.91% 83.81% -0.11% ========================================== Files 6 6 Lines 342 346 +4 ========================================== + Hits 287 290 +3 - Misses 55 56 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sisyphusSmiling commented 1 month ago

Maybe change the parameter code: String of the event StagingStatusUpdated to codeHash: [UInt8; 32] to make the event less stringly typed and reduce the overhead of hex-encoding

Makes sense. cc-ing @bluesign in case his tooling depends on events at all. I think not, but tagging just in case