onflow / flip-fest

A backlog of all the available tasks to complete for Flow's FLIP Fest.
50 stars 39 forks source link

New Tool: Block explorer GUI - Milestone 4 - Flippers #119

Closed bartolomej closed 3 years ago

bartolomej commented 3 years ago

New Tool: Block explorer GUI - Milestone 4

Description

This PR is for issue #2

This submission includes implementation of remaining minimum feature set to be fully functional in a bare-bones UI, additionally some optional features are included.

Features submitted

Submission Links & Documents

Requirements Check

Other Details

kerrywei commented 3 years ago

Hey @janezpodhostnik , I'm temporarily passing this to you given mac is off for two days + you are checking milestone 3. let me know if there's too much on your plate :)

janezpodhostnik commented 3 years ago

Good work!

I left related comments on milestone 3 https://github.com/onflow/flip-fest/pull/89#issuecomment-958118594

10thfloor commented 3 years ago

Hey all, just looked through the React code, overall really well done! I'm happy to accept all milestones up to and including 3. Do make an extra effort for the final milestone to make sure the UI is polished, and visually consistent. If we're going to feature your project in the community, you want to make sure to put your best foot forward.

bartolomej commented 3 years ago

@10thfloor Awesome, thank you! :sparkles: I agree, we will tweak the UI a bit, we have some inconsistencies defined in the issue #59, but we would like to hear if you noticed any other that we are missing. We are also in the process of finishing of a few more changes mentioned by janez in his comment here: #89 (comment).

bartolomej commented 3 years ago

@10thfloor Some inconsistencies, that were defined in https://github.com/onflow/flip-fest/pull/59 were fixed and merged into master. Let us know if you notice any other inconsistencies that should be fixed. 🙂

kerrywei commented 3 years ago

Great work @bartolomej ! I'm merging in this PR as the milestone has been achieved. Will leave the discussion of UI consistency between you and @10thfloor