search

onflow / flip-fest

A backlog of all the available tasks to complete for Flow's FLIP Fest.
50 stars 39 forks source link

Playground: Fix client-side errors in the playground frontend #58

Open psiemens opened 3 years ago

psiemens commented 3 years ago

👋   If you are interested in working on this issue, please check out the Getting Started guide on HackerEarth!

Description (Problem Statement)

The Flow Playground frontend app throws a number of console errors in product. Those errors shouldn't be there.

Each error is documented in an issue:

Your task is to eliminate these errors and, when applicable, refactor the code to avoid similar errors in the future.

Experience Required

Milestone Requirements

  1. Eliminate each error referenced in the issues above. When applicable, refactor the code to avoid similar errors in the future.

Other Requirements

Code standards or guidelines

Judging Criteria

Resources

hichana commented 3 years ago

Hello @psiemens I'd like to work on this issue.

My GH profile: https://github.com/hichana

My hacker earth team name is here: https://www.hackerearth.com/challenges/hackathon/flip-fest/dashboard/ae2cb67/team/

psiemens commented 3 years ago

Sounds good, thanks @hichana!

tigco commented 3 years ago

hey @hichana , are you still working on this?

hichana commented 3 years ago

Hi @tigco , I am definitely still working on this. Actually, my "0.5" PR resolves the issues completely, so in that sense it is complete. I have, however, investigating further optimizations which I described in my PR here: https://github.com/onflow/flip-fest/pull/59

wander1ust commented 3 years ago

Yup, I can confirm. Minor code deletions will eliminate the errors thrown. First three errors are related to React router Redirect + componentDidCatch & last error is due to non-unique, duplicate key prop. I don't think any refactoring is needed, so I'm guessing this issue will be closed soon.

hichana commented 3 years ago

Hi @psiemens I read that approval is needed for each of our milestones in order to be considered a solution to a FLIP issue, so I'm posting my two PRs to the flip-fest repo here. Together they comprise my solution to this FLIP issue, but I made it in such a way that the first or the second can be ultimately used. I'm open to any feedback you might have as well. Thanks

https://github.com/onflow/flip-fest/pull/59 https://github.com/onflow/flip-fest/pull/77

MaxStalker commented 2 years ago

Congrats, @hichana on finishing work for this issue! 🎉 Much appreciated 🙇

kimcodeashian commented 2 years ago

Good day @hichana!

Thanks so much for all your hardwork & participation. In order to finalize winners & prepare for prize payout, we'll need the following actions from your end.

Please provide the following information by Nov 17, 2021, (in this GH Issue is fine):

1. Team Information

🎖IMPORTANT: We will only proceed with prize payouts once all members have confirmed with 👍 on the post.

2. Video Demo (optional)

We will be hosting Closing Ceremonies on November 23rd, 8AM PT where we'll having closing remarks from Dete & will be announcing the winners! I'll share the details here before Nov 17.

hichana commented 2 years ago

Thank you :)

Team Information:

kimcodeashian commented 2 years ago

Hey folks,

We've received and reviewed over 82 submissions! What an amazing community on Flow! To commemorate all the hard work done, we have finalized winners and will be announcing them during our Closing Ceremony on Nov 23rd, 8AM PT. Be sure to join us - there may be some attendance prizes & a keynote from our CTO, Dete 😉!

RSVP here so you don't miss out! See you then!