Non-custodial wallets #28 - Milestone 4 - Zay Codes

aishairzay commented 3 years ago

Non-custodial wallets #28 - Milestone 4 - Zay Codes

Description

This PR is for issue #28 .

Previous milestone submissions here: #54 , #84 , #88

The full scope of milestones as described in issue #28 have been completed.
Included in the wallet product now is:
Authentication, authorization, pre-authorization support
UX for the aforementioned features, and for a wallet pop-up UI to manage accounts, switch between networks, view information about an account.
Ability to buy FLOW or FUSD with FIAT via MoonPay directly in the wallet
Secure private key storage, and temporary unlocks via a password that is NOT stored on disk
Fully non-custodial primary flow with no external dependencies (No risk of failure authorizing a transaction aside from the Flow blockchain itself being down.)
No custodial service involved or data collected from users
Documentation
Unit testing for essential pieces of code, primarily revolving around account management/storage and key management/storage

Not included in the deliverable (yet, we'd like to address these after flip-fest in order to get closer to releasing an MVP publicly) :

E2E testing
User signature support
Unfilled UI areas filled in
Better/more intuitive UX + UI
Integrate with new FCL wallet support
Wallet branding/naming
We would like to reach a releasable MVP state past the current implementation, which will require more time past October.

The additional RFP listed items would likely be added after an MVP is released.

Submission Links & Documents

Some GIFs of the extension working:

Authn + Preauthz + Authz Popups are ugly right now, because we can not modify them per FCL. Currently using FCL's pop-up for the service type, but plan to use the new extension one when it is more ready, which we can then customize to look better: https://gyazo.com/a0a2e39ad5fa474ee95fa97692ddd157

Popup UI https://gyazo.com/99421332be463db4dcfa1ea133b2101c

Source and readme with information is here: https://github.com/Zay-Codes-Lab/zay-wallet <- Currently private, will be opened up later. Ping me on discord for fastest permission add (amit#4491)

Documentation here: https://github.com/Zay-Codes-Lab/zay-wallet/tree/main/docs

Requirements Check

Have have you met the milestone requirements? Yes
Have you included tests (if applicable)? Yes
Have you met the contribution guidelines of the repos you have submitted code to (if applicable)? N/A
If this is the last milestone:
- Demonstrate that you've met all the acceptance criteria (link to code, demos, instructions to run etc.) Code and demos link is above, instructions to run included in README.
- Demonstrate that you've met all milestone requirements and highlight any extensions or additional work done. Info in previous section
- Include a payout structure by percentage for each team member (ie. Bob: 20%, Alice: 80%). (Amit 33.4%, Tyler 33.3%, Omar 33.3%) Can reach out to me for details, we can distribute ourselves as well. amit@zay.codes or amit#4491 on discord

Other Details

Is there anything specific you'd like the PoC to know or review for? Same notes as last milestone apply, and I think previous sections should address most items, let me know if you have any questions or comments!

gregsantos commented 3 years ago

Will have a chance to review M4 tomorrow @aishairzay

gregsantos commented 3 years ago

Still waiting for some testnet issues to finish testing for approval. Wanted to suggest something, though not required. Mentioned the double popup issue needing explicit approval by user. Implementing the pre-authz service as a backchannel HTTP/POST might be a quick way to solve. Here's how Blocto defines for example

{
  "f_type": "Service",
  "f_vsn": "1.0.0",
  "type": "pre-authz",
  "uid": "blocto#pre-authz",
  "method": "HTTP/POST",
  "endpoint": "https://flow-wallet.blocto.app/api/flow/pre-authz",
  "params": {
    "sessionId": "GvTT_nhkX-vv44iXUiyp"
  }
}

And a link to the Wallet Provider Spec

gregsantos commented 3 years ago

MoonPay integration is nice! 🚀🌛 Slight UI issue as extension closes when switching tab/window to get the email login code. Can't continue transaction from where it was left off. Should the FLOW and FUSD balances and links be working? Not showing balance when using emulator account locally, so may be specific to that.

kerrywei commented 3 years ago

merge in the PR per Greg's comment. Congratulations team!

onflow / flip-fest