search

onflow / flips

Flow Improvement Proposals
24 stars 22 forks source link

FLIP 210: propose an improvement to entitlement mapping syntax #210

Closed dsainati1 closed 8 months ago

dsainati1 commented 9 months ago

Some feedback in Discord (https://discord.com/channels/613813861610684416/1159198731422412821) revealed some room for improvement in the visual clarity of entitlement mapping declarations. This proposes to make them more visually distinct.

jacob-tucker commented 9 months ago

I am a big fan of this because of the reasoning specified:

since one of them has default behavior for public access and the other prevents it

So this is a +1 from me.

If before Cadence 1.0 is released and there are further changes to default public access on behalf of mappings or regular entitlements, then we should revisit this again.

bjartek commented 9 months ago

+1

At this point cadence is verbose, and this makes it easier to reason about.

bluesign commented 9 months ago

+1

dsainati1 commented 8 months ago

We discussed this in the language design meeting today and the FLIP is approved.