search

onflow / flips

Flow Improvement Proposals
24 stars 22 forks source link

Update status of FLIP 120 #246

Closed tarakby closed 2 months ago

tarakby commented 5 months ago

update status to implemented

KshitijChaudhary666 commented 4 months ago

Hi @tarakby - this FLIP is not reflected on FLIP project tracker. Did you follow the process outlined in https://github.com/onflow/flips? Specifically please remember to do the following without which the FLIP won't get visibility on the project tracker -->

Create an issue by using one of the FLIP issue templates based on the type of the FLIP - application, governance, cadence or protocol. The title of the issue should be the title of your FLIP, e.g., "Dynamic Inclusion fees". Submit the issue. Note the issue number that gets assigned. Then, Create your FLIP as a pull request to this repository (onflow/flips). Use the issue number generated in step 2 as the FLIP number. And mention the FLIP issue by copying the GitHub URL or the issue in the comment section.

Thanks!

tarakby commented 4 months ago

Hey @KshitijChaudhary666, thanks for pointing the FLIP process steps.

I believe the FLIP process got updated after I created FLIP 120. You can notice the FLIP PR started on July 13, and at that time the FLIP number would be the PR number. The extra step 2 of going through creating an issue was added on August 23.

Btw the same happened for FLIP 123. I hope it's possible to manually fix the tracker for both.

KshitijChaudhary666 commented 4 months ago

Hey @KshitijChaudhary666, thanks for pointing the FLIP process steps.

I believe the FLIP process got updated after I created FLIP 120. You can notice the FLIP PR started on July 13, and at that time the FLIP number would be the PR number. The extra step 2 of going through creating an issue was added on August 23.

Btw the same happened for FLIP 123. I hope it's possible to manually fix the tracker for both.

Hey! Got it - thanks for sharing the details. Could you pls create two issues (for each flip) in the new format and mark the right "type" (Cadence) and "status" (implemented?) and that should bring them to the project tracker. Thanks, really appreciate it!

tarakby commented 4 months ago

If I create 2 issues, the FLIPs won't have the issues numbers because they were already merged long time ago (and we always referred to them as 120 and 123). Wouldn't that mess with the tracker?

vishalchangrani commented 2 months ago

If I create 2 issues, the FLIPs won't have the issues numbers because they were already merged long time ago (and we always referred to them as 120 and 123). Wouldn't that mess with the tracker?

Hi @tarakby - for such cases, l basically change the FLIP ID to be the issue ID (if the FLIP is fairly new). Else, create the issue and mention in the issue description the original FLIP it points to.

tarakby commented 2 months ago

here is the issue https://github.com/onflow/flips/issues/260. I also created the issue https://github.com/onflow/flips/issues/261 for a related FLIP.

Feel free to merge or close the current PR.