Add ability for user to specify excluded networks when generating a FLIX

onflow / flow-cli

The Flow CLI is a command-line interface that provides useful utilities for building Flow applications

https://onflow.org

Apache License 2.0

206 stars 62 forks source link

Add ability for user to specify excluded networks when generating a FLIX #1528

Closed bthaile closed 2 months ago

bthaile commented 2 months ago

Closes: https://github.com/onflow/flixkit-go/issues/58

Description

Address issue where users wants to exclude specific network(s) when generating a FLIX. Added new exclude-networks command line flag for FLIX command.

For contributor use:

[ ] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[ ] Code follows the standards mentioned here
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

bthaile commented 2 months ago

Don't different networks have different versions of Cadence? Can you elaborate on how this works please?

Yes, different networks need different version of cadence. This version is cadence v1 compatible. so user will have to pass in the networks that are cadence v1 compatible. They can use old version of flow-cli to get pre cadence v1 compatibility.

Eventually there will only be cadence v1. I don't see a reason to force filter what networks ppl can use flix to generate templates on. So I added a filter, which can be used in the future even after full upgrade to cadence v1 has taken place. I think it'll be useful.

sisyphusSmiling commented 2 months ago

Built and tried it out locally - seems to be generating FLIX just fine against previewnet!

bthaile commented 2 months ago

Built and tried it out locally - seems to be generating FLIX just fine against previewnet!

can you also execute the flix?

sisyphusSmiling commented 2 months ago

can you also execute the flix?

I wouldn't be able to execute the particular flix, but that's an edge case where the Previewnet version isn't the one that I need for me to be able to execute the template's transaction code. I'll try once EVM on Previewnet is updated and let you know, hopefully by EOD today.

chasefleming commented 2 months ago

Can you also update the pr title? Something that will work for the release notes please?

bthaile commented 2 months ago

Can you also update the pr title? Something that will work for the release notes please?

Good point, I changed the flag to Targets and updated the title and description to be more release notes friendly.

bthaile commented 2 months ago

Can you also update the pr title? Something that will work for the release notes please?

Made all the updates, does the title and description make sense?