onflow / flow-cli

The Flow CLI is a command-line interface that provides useful utilities for building Flow applications
https://onflow.org
Apache License 2.0
206 stars 66 forks source link

Fix Windows tests #1555

Closed jribbink closed 5 months ago

jribbink commented 5 months ago

Closes #1556

Description

Fixes our long-standing issue with Windows tests doing nothing :P. The CGO fixes we made a while back sovled half the issue, this solves the rest.

Example failing CI here (we used to have the issue that failing Windows tests didn't cause the to fail, this shows that it is fixed): https://github.com/onflow/flow-cli/actions/runs/8915898654/job/24486335666


For contributor use:

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.71%. Comparing base (3989c3d) to head (cb627bc). Report is 32 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1555 +/- ## ========================================== + Coverage 39.70% 39.71% +0.01% ========================================== Files 51 51 Lines 2944 3278 +334 ========================================== + Hits 1169 1302 +133 - Misses 1620 1814 +194 - Partials 155 162 +7 ``` | [Flag](https://app.codecov.io/gh/onflow/flow-cli/pull/1555/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/onflow/flow-cli/pull/1555/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | `39.71% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.