search

onflow / flow-cli

The Flow CLI is a command-line interface that provides useful utilities for building Flow applications
https://onflow.org
Apache License 2.0
206 stars 62 forks source link

Remove LICENSE and README files from the archice #1570

Open joshuahannan opened 1 month ago

joshuahannan commented 1 month ago

Problem

When installing the latest preview release of the CLI, I get an error:

sh -ci "$(curl -fsSL https://raw.githubusercontent.com/onflow/flow-cli/feature/stable-cadence/install.sh)"

Downloading version v1.18.0-cadence-v1.0.0-preview.23 ...
##################################################################################################################################################################################################### 100.0%
LICENSE: Can't unlink already-existing object
README.md: Can't unlink already-existing object
flow-cli: Can't create 'flow-cli'
tar: Error exit delayed from previous errors.

Steps to Reproduce

Not sure how to reproduce it because it isn't happening for others.

Acceptance Criteria

It sounds like LICENSE and README should not be in the archive at all, so we should remove them.

Context

Blocking me from being able to test the token standards and core contracts with the latest CLI.

jribbink commented 1 month ago

I think the cause of this issue is not running with sudo. But, yeah, agree we could remove those files 👍

joshuahannan commented 1 month ago

oh yeah, you're right. Thanks for catching that! I got it installed now