onflow / flow-cli

The Flow CLI is a command-line interface that provides useful utilities for building Flow applications
https://onflow.org
Apache License 2.0
206 stars 62 forks source link

Fix contract/dependencies conflict checker #1600

Closed chasefleming closed 1 month ago

chasefleming commented 1 month ago

Closes #1599


For contributor use:

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 39.61%. Comparing base (9d33723) to head (85cc0c2).

Files Patch % Lines
internal/dependencymanager/dependencyinstaller.go 23.07% 8 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1600 +/- ## ========================================== - Coverage 39.95% 39.61% -0.35% ========================================== Files 51 51 Lines 3346 3345 -1 ========================================== - Hits 1337 1325 -12 - Misses 1841 1851 +10 - Partials 168 169 +1 ``` | [Flag](https://app.codecov.io/gh/onflow/flow-cli/pull/1600/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/onflow/flow-cli/pull/1600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | `39.61% <23.07%> (-0.35%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.