onflow / flow-cli

The Flow CLI is a command-line interface that provides useful utilities for building Flow applications
https://onflow.org
Apache License 2.0
206 stars 62 forks source link

Handle transaction result errors in `flow migrate stage` #1607

Closed jribbink closed 1 month ago

jribbink commented 1 month ago

Description

Errors while staging a contract (related to a failed transaction) are not properly reported. This handles that case.


For contributor use:

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.17%. Comparing base (ad513f5) to head (401fb13).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/stable-cadence #1607 +/- ## ========================================================== + Coverage 42.02% 42.17% +0.14% ========================================================== Files 60 60 Lines 4200 4202 +2 ========================================================== + Hits 1765 1772 +7 + Misses 2200 2197 -3 + Partials 235 233 -2 ``` | [Flag](https://app.codecov.io/gh/onflow/flow-cli/pull/1607/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/onflow/flow-cli/pull/1607/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | `42.17% <100.00%> (+0.14%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.