onflow / flow-cli

The Flow CLI is a command-line interface that provides useful utilities for building Flow applications
https://onflow.org
Apache License 2.0
206 stars 62 forks source link

Fix commit in `flow version` #1640

Closed jribbink closed 3 weeks ago

jribbink commented 3 weeks ago

Closes #1639

Description

Don't use git metadata, since it's tied to the commit which triggered the workflow. Since this is triggered by an action instead, it's presumable this is the cause of the issue.

Tag is updated as well just for consistency sake.


For contributor use:

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.08%. Comparing base (432fbc7) to head (64c9597).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1640 +/- ## ======================================= Coverage 39.08% 39.08% ======================================= Files 52 52 Lines 3536 3536 ======================================= Hits 1382 1382 Misses 1979 1979 Partials 175 175 ``` | [Flag](https://app.codecov.io/gh/onflow/flow-cli/pull/1640/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/onflow/flow-cli/pull/1640/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | `39.08% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.