Closed ianthpun closed 3 weeks ago
Attention: Patch coverage is 21.76991%
with 442 lines
in your changes missing coverage. Please review.
Project coverage is 33.91%. Comparing base (
dbb5eec
) to head (d0d1882
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you for keeping this updated!
I had a look at the conflict resolution (git log -1 -p -w --remerge-diff c053a6ac30c3de6d2265365d997085737f10e89e
) and it looks good. Unfortunately, due to https://github.com/onflow/flow-core-contracts/issues/433, these two changes need to get reverted (i.e. counter-intuitively, the lower versions are the actual current versions):
- github.com/onflow/flow-core-contracts/lib/go/templates v1.0.0
+ github.com/onflow/flow-core-contracts/lib/go/templates v1.2.4-0.20231016154253-a00dbf7c061f
- github.com/onflow/flow-core-contracts/lib/go/contracts v1.1.0 // indirect
+ github.com/onflow/flow-core-contracts/lib/go/contracts v1.2.4-0.20231016154253-a00dbf7c061f // indirect
The fixes (revert) for that, faebf02b45d5f4eea513931a080e3e3c8489b569 and 970ab037180534e99babc917f8a47ed1c4da56b6, look good!
@turbolent The versions I added were what are on the stable cadence branch currently? If I revert those changes, it breaks.
@chasefleming Yep, all I meant to do above was confirm that your fixes are correct 👍
For contributor use:
master
branchFiles changed
in the Github PR explorer