search

onflow / flow-cli

The Flow CLI is a command-line interface that provides useful utilities for building Flow applications
https://onflow.org
Apache License 2.0
206 stars 62 forks source link

Master branch now uses `flow-c1` in install-scripts #1660

Closed NtTestAlert closed 1 day ago

NtTestAlert commented 4 days ago

The documentation for installing flow-cli refer to master branch install scripts, as do probably a lot of scripts and pipelines.

In a recent merge the renaming of flow to flow-c1 was merged to master, breaking previous functionality and the desired interoperability

https://github.com/onflow/flow-cli/commit/b6c8838cfbbb9b59a504e2599cc9d4d182ff2096#diff-043df5bdbf6639d7a77e1d44c5226fd7371e5259a1e4df3a0dd5d64c30dca44fR130

NtTestAlert commented 4 days ago

(imo master branch should keep the flow exe name, the branches should include flow-c1. idk. it's not very important but breaks backward comp

chasefleming commented 4 days ago

We should freeze the code and try to avoid another homebrew release until Cadence 1.0 is on the master branch. I believe the install script looks at the releases. I think it would work in its current state. Are you experiencing an issue, or is this forward thinking for the next release if we have one?

turbolent commented 3 days ago

The install scripts should install the latest (non-prerelease) version by default, as flow, and have an option to install the latest pre-release version, as flow-c1.

ianthpun commented 2 days ago

this should let you install the old pre-1.0 binary

sudo sh -ci "$(curl -fsSL https://raw.githubusercontent.com/onflow/flow-cli/v1.20.5/install.sh)"