search

onflow / flow-core-contracts

Cadence smart contracts that define core functionality of the Flow protocol
https://onflow.org
The Unlicense
87 stars 49 forks source link

Implement FungibleTokenMetadataViews in FlowToken #369

Closed sisyphusSmiling closed 1 year ago

sisyphusSmiling commented 1 year ago

Issue To Be Solved

FlowToken needs to be updated with implementation of FungibleTokenMetadataViews introduced in FLIP 1087

Given the support for metadata, we may also consider implementing ViewResolver, though that's an optional consideration.

Suggest A Solution

Vaults should implement MetadataViews.Resolver and resolve FTView, FTDisplay, and FTVaultData.

If it's decided that FlowToken implements ViewResolver, then the relevant contract methods should also be added and resolve FTVaultData.

joshuahannan commented 1 year ago

@sisyphusSmiling Is this something you'll be able to work on or should I handle it?

sisyphusSmiling commented 1 year ago

@joshuahannan I can get this done if you have other work to complete. I l likely wouldn't get to it until next week as Hybrid Custody audit response and ETH Waterloo will have my attention this week

joshuahannan commented 1 year ago

I'm gonna work on this this week @sisyphusSmiling so no need for you to do it. Thanks for offering though!