search

onflow / flow-emulator

The Flow Emulator is a lightweight tool that emulates the behaviour of the real Flow network
https://onflow.org
Apache License 2.0
84 stars 49 forks source link

[Access] Created new gRPC methods for GetAccountBalance and GetAccountKeys. #707

Closed AndriiDiachuk closed 1 month ago

AndriiDiachuk commented 2 months ago

In this PR two new calls GetAccountBalance and GetAccountKeys were added to flow-emulator.

Related PRs: https://github.com/onflow/flow-go/pull/6144 https://github.com/onflow/flow/pull/1475

bluesign commented 1 month ago

Any chance to implement those? They are all probably can be implemented by calling GetAccount easily

AndriiDiachuk commented 1 month ago

Any chance to implement those? They are all probably can be implemented by calling GetAccount easily

@bluesign Added missing implementation.

turbolent commented 1 month ago

@AndriiDiachuk @peterargue What is the ETA for removing the replace statement?

I'd like to publish a new release once #708 is in, to get a new CLI release out.

AndriiDiachuk commented 1 month ago

@AndriiDiachuk @peterargue What is the ETA for removing the replace statement?

I'd like to publish a new release once #708 is in, to get a new CLI release out.

Hey, it was merged on my Saturday night, so will create new PR without replace statement on Monday.

turbolent commented 1 month ago

@AndriiDiachuk sounds good, thanks! No rush, was just asking for planning 👍

AndriiDiachuk commented 1 month ago

@AndriiDiachuk sounds good, thanks! No rush, was just asking for planning 👍

@turbolent Here is the new PR https://github.com/onflow/flow-emulator/pull/711.