search

onflow / flow-evm-gateway

FlowEVM Gateway implements an Ethereum-equivalent JSON-RPC API for EVM clients to use
https://developers.flow.com/evm/about
Apache License 2.0
11 stars 10 forks source link

Update to Cadence v1.0.0-preview.39 #367

Closed turbolent closed 3 months ago

turbolent commented 4 months ago

Description

Automatically update to:

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

Walkthrough

The updates across various files enhance type safety, streamline data handling, and upgrade dependencies to boost performance and maintainability. Notable changes include the replacement of deprecated methods, refinement of logging mechanisms, and the introduction of new data structures for improved encapsulation. These modifications underscore a commitment to efficient coding practices and robust functionality, ensuring the codebase remains agile and responsive to future needs.

Changes

Files Change Summary
go.mod, tests/go.mod Updated multiple dependencies, including Pebble to v1.1.1 and Cadence to v1.0.0-preview.39; included new dependency cockroachdb/fifo.
api/server.go, api/stream.go Improved logging setup and removed deprecated notifier handling in subscription management.
models/block.go, models/transaction.go Simplified handling of transaction hashes and event attributes by removing unnecessary hex decoding.
models/events.go Enhanced Transactions method to associate transaction receipts with block hashes.
services/ingestion/engine.go, services/ingestion/engine_test.go Modified event handling to use new event types from the events package; adjusted function signatures accordingly.
services/requester/requester.go Renamed and changed the type of a variable in the transaction signing process for better type safety.
tests/web3js/eth_deploy_contract_and_interact_test.js, tests/web3js/eth_non_interactive_test.js Improved formatting and assertions in test cases to reflect changes in blockchain behavior and enhance readability.

🐇 Version Song 🎶

With updates new and dependencies bright,
Our code takes flight, with versions right.
Bugs will flee and errors shrink,
As libraries new, in sync, we link.
🐰✨💻

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
turbolent commented 4 months ago

There are several changes in flow-go and geth which need to be resolved:

turbolent commented 3 months ago

@m-Peter @sideninja The fixes in the dependencies are merged now:

Releases have been tagged in the dependencies, and I updated everything again, which resulted in #382, which I merged into this PR.

It looks like the EVM implementation changed once again and block transaction hashes have been replaced by a transaction hash root. However, I don't know anything about these. From what I can tell this should be the last issue that has to be addressed. Let me know how I can assist!

cc @ramtinms

m-Peter commented 3 months ago

@turbolent We have incrementally fixed all the breaking changes, via:

So now we have github.com/onflow/cadence v1.0.0-preview.39 in https://github.com/onflow/flow-evm-gateway/pull/381, which a :heavy_check_mark: CI :pray:

sideninja commented 3 months ago

Closing this one in favour of https://github.com/onflow/flow-evm-gateway/pull/381 There are a lot of breaking changes that needs addressing.

turbolent commented 3 months ago

Awesome, great work @m-Peter and @sideninja! 👏