Closed m-Peter closed 2 months ago
The recent changes to the build workflow enhance the Docker image building process by replacing a hardcoded version with a dynamic retrieval of the latest Git tag. This automation ensures that the image is always built with the most recent version available, improving flexibility and reducing the need for manual updates.
Files | Change Summary |
---|---|
.github/workflows/build.yml |
Updated GATEWAY_VERSION to dynamically use the latest Git tag instead of a hardcoded version. |
🐰 In the code where rabbits play,
A version change brightens the day!
No more hardcoded, oh what a thrill,
The latest tag now fits the bill!
With every build, we hop and cheer,
For dynamic magic, we hold so dear! 🎉
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@m-Peter I don't believe it was. The first issue was complaining about this variable not being present if I remember correctly. The second was related to go version. Can you please check all release github actions that failed.
@sideninja Yeah, I did check. https://github.com/onflow/flow-evm-gateway/actions/runs/10098992697/job/27927205564 All the actions seem to have failed simply from the Golang version in Dockerfile. There was no related change to justify a failure to this command.
@m-Peter you are right, thanks!
This reverts commit 80112d0eb8702e535ec533b6440d3c3f93130e3e.
Description
The bug was actually coming from the Golang version in the Dockerfile: https://github.com/onflow/flow-evm-gateway/pull/386
For contributor use:
master
branchFiles changed
in the Github PR explorerSummary by CodeRabbit
New Features
Chores