onflow / flow-evm-gateway

FlowEVM Gateway implements an Ethereum-equivalent JSON-RPC API for EVM clients to use
https://developers.flow.com/evm/about
Apache License 2.0
11 stars 10 forks source link

Refactor interactions metrics #426

Closed sideninja closed 3 months ago

sideninja commented 3 months ago

Right now interactions with accounts metric is triggered when sending a transaction, but interaction can come from other sources.

We should refactor the account metric and add other network metrics in the ingestion of events. There we can digest a lot of information from what is going on on the network.

illia-malachyn commented 3 months ago

I'm encountering the same problem while working on gather fees metric on both Flow and EVM side. We must do that in the event ingestion rather than the requester module to also track interactions coming from other sources. However, we don't have enough information in the event ingestion engine for this metric. We index only EVM.TransactionExecuted and EVM.BlockExecuted events although I need FlowFees.FeesDeducted event to gather fees on the Flow side. I can extend the engine to track this event too but it raises the question of the gateway's responsibility - whether this is an appropriate place to gather this metric.