Closed illia-malachyn closed 1 month ago
[!WARNING]
Rate limit exceeded
@illia-malachyn has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 27 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between afea3c7fd6003c493cee436258d7d20ea137e60a and cf92c7b976d50084a10649a76211cccc0cee9ab5.
The recent changes enhance the functionality and observability of the system, particularly in transaction processing and metrics collection. Key modifications include the introduction of a new collector
parameter in the transaction pool, updates to dependency management, and improvements in fee tracking methods. These enhancements aim to improve performance, accuracy, and integration capabilities within the overall architecture.
Files | Change Summary |
---|---|
bootstrap/bootstrap.go |
Modified startServer to include a new collector parameter in NewTxPool . |
go.mod , tests/go.mod |
Updated dependencies, replacing github.com/onflow/flow-go with a forked version and adjusting other packages. |
metrics/collector.go , metrics/nop.go |
Introduced new methods for EVM and Flow fee collection in Collector and nopCollector implementations. |
services/requester/pool.go , services/ingestion/engine.go |
Enhanced the TxPool with a collector field and updated the Send method for fee tracking. |
services/requester/remote_state.go |
Renamed AllocateStorageIndex to AllocateSlabIndex , altering its return type and functionality. |
sequenceDiagram
participant Engine
participant Collector
participant TxPool
participant Transaction
Engine->>Transaction: Process Events
Transaction->>Engine: From() (Sender Address)
Engine->>Collector: EVMFeesCollected(Sender, GasUsed, GasPrice)
Engine->>TxPool: Send(Transaction)
TxPool->>Collector: FlowFeesCollected(Payer, Events)
🐇 In fields of code where rabbits play,
New features hop, they’re here to stay!
Metrics gather, fees align,
A brighter future, oh how divine!
With every change, we leap and bound,
In code’s warm burrow, joy is found! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
This covers
Report fees paid on Flow and EVM side as a metric
.EVM fees (gas) are gathered in the event ingestion. Flow fees are collected in the requester package only, therefore we will miss some fees paid on the Flow side. This is done intentionally and is a topic to discuss
Depends on https://github.com/onflow/flow-go/pull/6304
Summary by CodeRabbit
New Features
Bug Fixes
8080
to8081
.Chores