Closed illia-malachyn closed 1 month ago
The recent changes focus on restructuring the metrics collection system within the application. Key modifications include removing the logger
parameter from function signatures and enhancing type safety by adjusting the handling of Ethereum account interactions. These updates streamline the monitoring process and improve maintainability across the codebase.
Files | Change Summary |
---|---|
bootstrap/bootstrap.go |
Removed collector from startServer parameters and updated the Start function to instantiate collector without the logger . |
metrics/collector.go , metrics/nop.go |
Updated EVMAccountInteraction to accept *common.Address instead of string . Removed logger from NewCollector . Streamlined metric registration using promauto . |
services/ingestion/engine.go |
Added e.collector.EVMAccountInteraction(tx.To()) call in processEvents to log EVM account interactions. |
services/requester/requester.go |
Removed collector from the EVM struct and its constructor NewEVM . Eliminated interaction logging in SendRawTransaction . |
sequenceDiagram
participant Client
participant Engine
participant Collector
Client->>Engine: Send Transaction
Engine->>Collector: Log EVM Account Interaction
Engine-->>Client: Acknowledge Transaction
🐇 In the meadow where code does play,
Metrics dance in a simpler way.
No more clutter, just pure delight,
EVM whispers in the moonlight.
With every hop, our code is free,
A joyful leap from me to thee! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
This partially? covers https://github.com/onflow/flow-evm-gateway/issues/426
Summary by CodeRabbit
New Features
Improvements
Refactor
Bug Fixes