Closed m-Peter closed 1 month ago
The changes primarily improve the logging and request handling in the ServeHTTP
method of the httpServer
struct. By introducing a new variable for parsed JSON request bodies and adapting the responseHandler
struct, the logging mechanism now captures detailed request and response information. This enhances debugging and monitoring capabilities, addressing the need for more comprehensive log entries.
Files | Change Summary |
---|---|
api/server.go |
Enhanced logging for request and response handling by introducing requestBody variable and updating log mechanisms. |
Objective | Addressed | Explanation |
---|---|---|
Logging of API responses lacks certain fields (#440) | ✅ |
🐇 In the meadow, I hop with glee,
Logs now tell tales of requests with clarity!
With fields so bright, errors take flight,
Our API's whispers now shine in the night.
Oh, what joy, this change brings to me! 🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Closes: https://github.com/onflow/flow-evm-gateway/issues/440
Description
Logging of JSON-RPC request fields, such as
method
¶ms
was not logged at all:The result now looks like:
This matches the logging we do for API requests as well.
For contributor use:
master
branchFiles changed
in the Github PR explorerSummary by CodeRabbit
New Features
Bug Fixes
Documentation