onflow / flow-evm-gateway

FlowEVM Gateway implements an Ethereum-equivalent JSON-RPC API for EVM clients to use
https://developers.flow.com/evm/about
Apache License 2.0
11 stars 9 forks source link

Empty `miner` field on `eth_getBlockByNumber` #454

Closed m-Peter closed 1 month ago

m-Peter commented 1 month ago

As specified in the Ethereum JSON-RPC API specification, the miner field should containing:

Address of the beneficiary to whom the mining rewards were given.

Certain tools, such as Blockscout, use the value of this field for some of their views, e.g. https://evm-testnet.flowscan.io/tx/0x09931533bfc3f5854d9d017e1b71f14a15d4f22c1ec0d00166a947bd9d023d68?tab=state Where we can see that the miner is 0x0000000000000000000000000000000000000000, and it has received fee rewards. The above value for miner is returned by this line: https://github.com/onflow/flow-evm-gateway/blob/main/api/models.go#L273.

Relevant discord thread: https://discord.com/channels/613813861610684416/1273722753488261244