Closed m-Peter closed 1 month ago
The recent changes streamline the configuration process by consolidating the handling of EVM and flow network IDs in the FromFlags
function. The code now supports the flow-mainnet
value for the --flow-network-id
flag, enhancing user feedback for invalid inputs. This simplifies the logic and improves clarity, making it easier to manage network configurations.
Files | Change Summary |
---|---|
config/config.go |
Removed unused evmNetwork variable; integrated cfg.EVMNetworkID logic into flow switch; added flow-mainnet case; expanded error message for unsupported IDs. |
Objective | Addressed | Explanation |
---|---|---|
Allow mainnet value for --flow-network-id config flag (#[456]) |
✅ |
🐇 In the meadow, the code does flow,
Withmainnet
support, watch it grow!
Flags now dance with clear delight,
Configs shine, all is right!
Hooray for changes, quick and neat,
In our code, we find the beat! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Closes: https://github.com/onflow/flow-evm-gateway/issues/456
Description
The
--flow-network-id
CLI flag now accepts the theflow-mainnet
value. In addition to that, we remove the--evm-network-id
CLI flag, as we can deduce this config value simply from the--flow-network-id
flag.For contributor use:
master
branchFiles changed
in the Github PR explorerSummary by CodeRabbit
New Features
flow-mainnet
.Bug Fixes
Documentation