Closed Kay-Zee closed 1 month ago
The update to the FromFlags
function in config/config.go
introduces a command-line flag for selecting the private key algorithm for the COA private key. A new variable, keyAlg
, is added to enable this selection, defaulting to ECDSA_P256
. The function has been modified to decode the private key based on the specified algorithm, returning an error for unrecognized values.
Files | Change Summary |
---|---|
config/config.go |
Modified the FromFlags function to include a new command-line flag for specifying the private key algorithm with a new variable keyAlg . Logic updated to handle key decoding based on the selected algorithm. |
In the garden of code, a change takes flight,
With flags and algorithms shining bright.
Rabbits hop by, in algorithms they trust,
Decoding keys, in us they must.
A dance of logic, so clever and spry,
In the land of config, we leap and we sigh! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@sideninja any reason to not allow this key type? i couldn't think of any but let me know if i missed something
Closes: #???
Description
Adds
ECDSA_secp256k1
as an option for the COA Private keyFor contributor use:
master
branchFiles changed
in the Github PR explorerSummary by CodeRabbit
New Features
ECDSA_P256
, with support forECDSA_secp256k1
and handling for unrecognized algorithms.Bug Fixes