Closed sideninja closed 1 month ago
The changes involve the removal of the RestartableEngine
struct and its associated methods from the models/engine.go
file, simplifying the engine's functionality by eliminating the restart mechanism. Additionally, the startIngestion
function in bootstrap/bootstrap.go
has been updated to directly use the eventEngine
, removing the retry logic encapsulated in the now-removed restartableEventEngine
.
File | Change Summary |
---|---|
bootstrap/bootstrap.go | Simplified the startIngestion function by directly utilizing the eventEngine and removing retry logic. |
models/engine.go | Removed RestartableEngine struct and its methods, eliminating the restart mechanism and related functionality. |
Objective | Addressed | Explanation |
---|---|---|
Implement ingestion engine restart logic (#85) | ❌ | The restart logic was removed instead of implemented. |
Monitor for events tracked or panic/restart (#85) | ❌ | No monitoring or restart logic was introduced. |
🐰 In the code, a twist and turn,
The engine's fate, we now discern.
No more retries, just a single flow,
Through the logs, our progress will show.
Simplified paths, let the data stream,
Hopping along, we chase our dream! 🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Closes: #85
Description
Remove restartable engine complexities since the environment is taking care of restarts in case of panic and this just adds complexity and opportunity for bugs.
For contributor use:
master
branchFiles changed
in the Github PR explorerSummary by CodeRabbit
New Features
Bug Fixes
Chores
RestartableEngine
struct and related methods, focusing on core engine functionalities.