coderabbitai[bot]
commented
2 months ago [!WARNING]
Rate limit exceeded
@m-Peter has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 1 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between fd3d2663fcccf1522c108bd0782aaf2eef7056de and 623f987eadf9c716bb89573ddfe74977c14b2baf.
Walkthrough
The changes introduce modifications to the transaction function and related methods to incorporate a new coinbase parameter, allowing for greater flexibility in specifying the coinbase address during transactions. This update affects various files, including the core transaction handling and test configurations, ensuring that the coinbase address can be dynamically set and verified in tests.
Changes
| Files | Change Summary |
|---|---|
services/requester/cadence/run.cdc, services/requester/requester.go |
Added a coinbase parameter to the transaction function and SendRawTransaction method, altering how the coinbase address is handled. |
tests/helpers.go, tests/web3js/config.js |
Introduced a new constant for the coinbase address in tests and updated configuration to reflect this change. |
tests/web3js/eth_transaction_type_fees_test.js |
Enhanced transaction fee tests with additional assertions for coinbaseBalance. |
tests/web3js/eth_non_interactive_test.js |
Updated assertions to validate the correct coinbase address based on new configuration. |
Sequence Diagram(s)
sequenceDiagram
participant User
participant EVM
participant TransactionHandler
User->>EVM: Send transaction with coinbase
EVM->>TransactionHandler: Process transaction with coinbase
TransactionHandler->>EVM: Return transaction result
EVM->>User: Send transaction resultAssessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
eth_coinbase should reflect the actual coinbase being used on EVM.run (#490) |
✅ |
Poem
🐇 In the meadow where bunnies hop,
A coinbase change makes our hearts stop!
With new addresses, we dance and play,
Transactions brightening up our day!
Hooray for the code, let’s cheer and sing,
For every hop, a new joy it brings! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Closes: https://github.com/onflow/flow-evm-gateway/issues/490
Description
Right now, although we have the
--coinbaseconfig flag, which is returned ineth_coinbase, we keep using the COA's address inEVM.run. The EVM Gateway operators should have the ability to specify whatever address they want for the--coinbaseflag, this could be an EOA, or they can even choose the use the COA's address. Furthermore, there is a chance that some tool out there might complain about the fact thateth_coinbaseis not the address collecting the fees.For contributor use:
masterbranchFiles changedin the Github PR explorerSummary by CodeRabbit
New Features
Bug Fixes
Tests