Closed m-Peter closed 4 weeks ago
[!CAUTION]
Review failed
The pull request is closed.
The changes involve enhancements to the logging functionality in the Call
and EstimateGas
methods of the EVM
struct within the services/requester/requester.go
file. The logging of the data
parameter is now encoded in hexadecimal format, and error logging is refined to exclude specific error types. Additionally, successful gas estimation logs now include more contextual information regarding the heights involved.
File Path | Change Summary |
---|---|
services/requester/requester.go | Updated logging in Call method to use hexadecimal encoding for data . Enhanced error logging in EstimateGas to filter specific errors and include additional context in success logs. |
sequenceDiagram
participant Client
participant EVM
participant Logger
Client->>EVM: Call(data)
EVM->>Logger: Log hex-encoded data
Logger-->>EVM: Log entry created
Client->>EVM: EstimateGas(data)
EVM->>Logger: Check error type
alt Error not ErrHeightOutOfRange
EVM->>Logger: Log error details with hex data and heights
end
EVM->>Logger: Log success with evm-height and cadence-height
Logger-->>EVM: Log entry created
🐰 In the meadow where data flows,
Hexagons dance, and the logging glows.
Errors filtered, clear as day,
With heights in logs, they guide the way.
Hooray for changes, let’s hop and cheer,
For clarity blooms, and the path is clear! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Description
Just like we do for
Call
/GetNonce
/GetCode
/GetBalance
, we should handleErrHeightOutOfRange
inEstimateGas
as well.For contributor use:
master
branchFiles changed
in the Github PR explorerSummary by CodeRabbit