Closed sideninja closed 3 weeks ago
[!WARNING]
Rate limit exceeded
@sideninja has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 9 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between f5adb56afa9bd5cb18d03dfbb16bb28f2d52e50f and 96d76f7de2cdf6509d2c9d497b3cffa511ea3bbc.
The changes introduce a new field, FixedHash
, to the Block
struct in models/block.go
, enhancing hash management. The Hash()
method is updated to prioritize this fixed hash when available. Additionally, a new function for decoding legacy block events is added. Corresponding tests in models/block_test.go
validate these functionalities, ensuring that both hashing and legacy event decoding operate correctly.
Files | Change Summary |
---|---|
models/block.go |
Added FixedHash field to Block , modified Hash() method, introduced decodeLegacyBlockEvent , and added blockEventPayloadV0 type. |
models/block_test.go |
Added tests for fixed hash functionality and legacy block event decoding, along with a helper function for hash conversion. |
tests/web3js/eth_non_interactive_test.js |
Updated expected block size in a test case. |
Objective | Addressed | Explanation |
---|---|---|
Block hash consistency with evm-testnet.flowscan (##509) | ✅ | |
Ensure legacy data can be processed correctly (##509) | ✅ |
In the meadow, I hop and play,
New hashes here to brighten the day!
With fixed values, we leap and bound,
Legacy events, joyfully found.
Oh, what fun in code we weave,
A rabbit's cheer, we all believe! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Closes: #509
Description
Fix dropping of RLP encoding unexported field of fixed hash so it persists when decoded from the index.
For contributor use:
master
branchFiles changed
in the Github PR explorerSummary by CodeRabbit
New Features
FixedHash
field in theBlock
structure for consistent hash calculations.Bug Fixes
Tests