search

onflow / flow-evm-gateway

FlowEVM Gateway implements an Ethereum-equivalent JSON-RPC API for EVM clients to use
https://developers.flow.com/evm/about
Apache License 2.0
11 stars 9 forks source link

Reuse client for storage query #542

Closed sideninja closed 2 weeks ago

sideninja commented 2 weeks ago

Description

Reuse the client for storage inspection.

For contributor use:

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The pull request introduces modifications across multiple files, enhancing gRPC client functionality and simplifying dependency management. Key changes include updating the setupCrossSporkClient function to support larger message sizes, redefining the newRemoteLedger function to accept a pre-established client, and updating the go.mod file to reflect a new version of the flow-go-sdk dependency. These adjustments aim to improve data handling and streamline client management.

Changes

Files Change Summary
bootstrap/bootstrap.go Modified setupCrossSporkClient to include a new parameter for maximum receive message size (1 GB) in the gRPC client creation process.
go.mod, tests/go.mod Updated version of github.com/onflow/flow-go-sdk from v1.0.0-preview.54 to v1.0.0-preview.56.
services/requester/remote_state.go Changed newRemoteLedger function to accept an executiondata.ExecutionDataAPIClient instead of a host string, simplifying connection management.
services/requester/remote_state_test.go Refactored tests to directly create a gRPC client and retrieve the latest block header, removing the getPreviewnetLatestHeight function and streamlining ledger initialization.

Possibly related PRs

🐰 In the code where the bunnies hop,
New changes come, and we can't stop!
With larger messages, we now can play,
A smoother ledger for every day.
Dependencies updated, all in a row,
Hooray for the changes, let the data flow! 🌟

[!TIP]

OpenAI O1 model for chat - We have deployed OpenAI's latest O1 model for chat. - OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model. - Please share any feedback with us in the [discussions post](https://discord.com/channels/1134356397673414807/1283929536186155099).
Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 61ca558cc9de237ee34374d64b19240259b3c0d9 and 67b557f95dbddd0d0d170ea87e790e5da4aab0b3.
Files selected for processing (2) * bootstrap/bootstrap.go (2 hunks) * services/requester/remote_state_test.go (3 hunks)
Files skipped from review as they are similar to previous changes (1) * bootstrap/bootstrap.go
Additional comments not posted (3)
services/requester/remote_state_test.go (3)
Line range hint `21-45`: **Skipping review.** This test function is not directly affected by the changes made in this PR. The function relies on the `newPreviewnetLedger` function, which has been modified and will be reviewed separately. --- `57-63`: **LGTM!** The changes made to the `Benchmark_RemoteLedger_GetBalance` function improve the efficiency and clarity of the code by: 1. Consolidating the logic for establishing the gRPC connection and retrieving the latest block height into a more streamlined process. 2. Simplifying the control flow and reducing the number of steps required to obtain the latest block height. 3. Introducing a new parameter `grpcClient.WithGRPCDialOptions(grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(1024*1024*1024)))` to the `grpcClient.NewClient` function to support larger message sizes. The changes are well-structured and enhance the overall quality of the code. Also applies to: 70-70 --- `85-87`: **LGTM!** The changes made to the `newPreviewnetLedger` function improve the efficiency and clarity of the code by: 1. Consolidating the logic for establishing the gRPC connection and retrieving the latest block height into a more streamlined process. 2. Simplifying the control flow and reducing the number of steps required to obtain the latest block height. 3. Introducing a new parameter `grpcClient.WithGRPCDialOptions(grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(1024*1024*1024)))` to the `grpcClient.NewClient` function to support larger message sizes. 4. Returning `newRemoteLedger(execClient, latest.Height)` instead of using the removed `getPreviewnetLatestHeight` function, which is consistent with the changes made in the `Benchmark_RemoteLedger_GetBalance` function. The changes are well-structured and enhance the overall quality of the code. Also applies to: 91-91, 93-95, 98-98
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.