onflow / flow-evm-gateway

FlowEVM Gateway implements an Ethereum-equivalent JSON-RPC API for EVM clients to use
https://developers.flow.com/evm/about
Apache License 2.0
11 stars 10 forks source link

Update constant for block gas limit #564

Closed m-Peter closed 1 month ago

m-Peter commented 1 month ago

Closes: https://github.com/onflow/flow-evm-gateway/issues/558

Description

Update the constant's value to 120M, as that is the theoretical block gas limit.


For contributor use:

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The pull request modifies the blockGasLimit constant in the api/encode_transaction.go file, increasing its value from 15,000,000 to 120,000,000 to support larger transactions. Additionally, enhancements were made to the test cases in tests/web3js/eth_non_interactive_test.js to validate block retrieval and fee history, including assertions related to the new gas limit.

Changes

File Change Summary
api/encode_transaction.go Updated blockGasLimit from 15_000_000 to 120_000_000 to accommodate larger transactions.
tests/web3js/eth_non_interactive_test.js Enhanced test cases for block retrieval and fee history, including assertions for gasLimit.

Assessment against linked issues

Objective Addressed Explanation
Gas Limit should be increased to accommodate higher gas usage (558)

Possibly related PRs

Suggested labels

Improvement

Poem

🐰 In the meadow where transactions bloom,
A gas limit raised, dispelling the gloom.
With tests enhanced, we hop with delight,
Validating blocks, our future is bright!
So here's to the changes, let’s cheer and play,
For a smoother tomorrow, hip-hip-hooray! 🎉


Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 78467d58576f8bb5d5bd131bdf9cbbcee21887cb and 72b27dd934988e70be02f66b8ded8ad7866e51d3.
Files selected for processing (2) * api/encode_transaction.go (1 hunks) * tests/web3js/eth_non_interactive_test.js (2 hunks)
Additional comments not posted (3)
api/encode_transaction.go (1)
`12-12`: **Verify the rationale behind setting the block gas limit to `120M`.** The linked issue #558 suggests increasing the `gasLimit` to the maximum cap of `30M`, given that the `gasUsed` exceeded `15M` of the limit. However, the updated constant value of `120M` is significantly higher than the suggested limit. Please consider the following: - Provide a clear justification for setting the block gas limit to `120M` and ensure it aligns with the system's requirements and constraints. - Consider using a more conservative limit, such as the `30M` mentioned in the linked issue, unless there is a compelling reason for the higher value. - Conduct thorough testing and validation to assess the impact of the increased gas limit on the system's performance, security, and resource utilization.
tests/web3js/eth_non_interactive_test.js (2)
`31-31`: **LGTM!** The assertion correctly verifies that the `block.gasLimit` matches the updated value of `120000000n`, which aligns with the PR objective of increasing the block gas limit to 120M. --- `383-383`: **Verify the `gasUsedRatio` value.** Please ensure that the updated `gasUsedRatio` value of `[0, 0.006205458333333334]` is correct and aligns with the expected behavior considering the increased block gas limit. Provide additional context or justification for the change if necessary.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.