Open peterargue opened 2 days ago
The changes in this pull request enhance the functionality of the metrics collector by introducing a new method for tracking EVM transactions and updating existing methods to increment counters accordingly. The Collector
interface is modified to include the new method, and corresponding counters are added to the DefaultCollector
struct. Additionally, other components are updated to utilize the new functionality, including the nopCollector
and the event processing logic in the Engine
struct.
File | Change Summary |
---|---|
metrics/collector.go, metrics/nop.go | Added EVMTransactionIndexed(count int) method to the Collector interface and nopCollector struct. Introduced evmBlockIndexedCounter and evmTxIndexedCounter in DefaultCollector . |
services/ingestion/engine.go | Updated processEvents method to include a call to e.collector.EVMTransactionIndexed(len(events.Transactions())) for tracking indexed transactions. |
services/requester/cross-spork_client.go | Modified add method of sporkClients to include a logger parameter for enhanced logging when adding new spork clients. |
services/requester/cross-spork_client_test.go | Updated test cases in Test_CrossSporkClients to reflect changes in the add method requiring a logger parameter. |
Collector
interface, which is directly related to the modifications made in the main PR that also enhance the metrics collector's functionality.Improvement
, EVM
In the meadow where metrics grow,
A rabbit hops with joy, you know!
EVM transactions now in sight,
Counting blocks with all its might.
With each new method, we shall cheer,
For data's dance is finally here! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Closes: #???
Description
Add metrics for block and transaction indexing. Also add logging for the spork client block ranges on startup.
For contributor use:
master
branchFiles changed
in the Github PR explorerSummary by CodeRabbit
New Features
Bug Fixes
Tests