onflow / flow-go

A fast, secure, and developer-friendly blockchain built to support the next generation of games, apps, and the digital assets that power them.
GNU Affero General Public License v3.0
531 stars 170 forks source link

[Access] Improve subscription `Streamer` functionality to graceful shutdown on demand #5561

Open Guitarheroua opened 3 months ago

Guitarheroua commented 3 months ago

Problem Definition

The Streamer now should handle one more extra block to gracefully shut the subscription (see discussion in PR). There should be a way to send the reply and shut down the subscription immediately after that on demand.

For this, the Streamer, and perhaps other subscription core functionalities, should be improved to react to shutdown signals and handle replies and subscriptions properly.

Definition of Done

github-actions[bot] commented 2 weeks ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.