search

onflow / flow-go

A fast, secure, and developer-friendly blockchain built to support the next generation of games, apps, and the digital assets that power them.
GNU Affero General Public License v3.0
532 stars 177 forks source link

Add a Time To Seal metric to access node to track time it takes to seal a transaction #6448

Closed vishalchangrani closed 2 weeks ago

vishalchangrani commented 2 months ago

Problem Definition

What problem is this solving?

Currently, there are Access node metrics to track Time To Finalization (TTF) and Time To Execute (TTE) for a transaction. However, we are missing the metric to track Time To Seal (TTS) for a transaction.

Proposed Solution

What are the proposed solutions to this problem?

Add a new metric that tracks TTS.

Definition of Done

What tests must pass for this issue to be considered solved?

The TTS metric is available and there is an internal Grafana panel that shows this metric.

peterargue commented 1 month ago

@vishalchangrani how urgent is this?

vishalchangrani commented 2 weeks ago

hey @peterargue , @franklywatson - can we prioritize this? It will help us nail down our time to hard finality number and update our docs and marketing material.

franklywatson commented 2 weeks ago

It's already in progress and under review. Hopefully be done soon

AndriiDiachuk commented 2 weeks ago

@franklywatson I fixed last two comments and all the checks are passing, so if Leo will have some time he could review it and approve?

Guitarheroua commented 2 weeks ago

@vishalchangrani Should this one be backported to the v0.37 release?

vishalchangrani commented 1 week ago

@vishalchangrani Should this one be backported to the v0.37 release?

yes, please can you back port? The next network upgrade is still far far away and it will help to have this metric live

AndriiDiachuk commented 1 week ago

@

@vishalchangrani Should this one be backported to the v0.37 release?

yes, please can you back port? The next network upgrade is still far far away and it will help to have this metric live

@vishalchangrani I created PR for backport to the v0.37: https://github.com/onflow/flow-go/pull/6605