onflow / flow-go

A fast, secure, and developer-friendly blockchain built to support the next generation of games, apps, and the digital assets that power them.
GNU Affero General Public License v3.0
533 stars 179 forks source link

Fix nil pointer dereference in SendAndSubscribeTransactionStatuses() func #6604

Open illia-malachyn opened 3 weeks ago

illia-malachyn commented 3 weeks ago

When you run the flow-go-sdk example for SendAndSubscribeTransactionStatuses, a nil pointer dereference crash occurs during runtime.

Steps to reproduce:

You should see an error in the emulator with nil pointer dereference error.

I assume the error is caused by flow-go implementation rather than flow-go-sdk wrapper one. I'd also suggest refactoring the implementation of this method as it was extended by quite a complex logic and became hard to reason about

illia-malachyn commented 3 weeks ago

cc @peterargue @AndriiDiachuk @Guitarheroua

illia-malachyn commented 3 weeks ago

flow-go-sdk examples are to be merged https://github.com/onflow/flow-go-sdk/pull/794