#110/ CollectionGuarantee type differs from protobuf schema

onflow / flow-jvm-sdk

Flow JVM SDK

Apache License 2.0

16 stars 16 forks source link

Closed lealobanov closed 3 days ago

lealobanov commented 1 week ago

Closes: #110

Update fields for FlowCollectionGuarantee model: https://github.com/onflow/flow/blob/master/protobuf/flow/entities/collection.proto#L13
Did not add signer_ids as it has been deprecated
Update related tests with new fields

For contributor use:

[ ] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the standards mentioned here.
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

github-actions[bot] commented 1 week ago

0 files -   54 0 suites - 54 0s :stopwatch: -23s 0 tests - 316 0 :heavy_check_mark: - 316 0 :zzz: ±0 0 :x: ±0

Results for commit 11f2ad52. ± Comparison against base commit f8afbfb3.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

0 files ±0 0 suites ±0 0s :stopwatch: ±0s 0 tests ±0 0 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0

Results for commit 11f2ad52. ± Comparison against base commit f8afbfb3.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

37 files ±0 37 suites ±0 6m 14s :stopwatch: -5s 70 tests ±0 69 :heavy_check_mark: - 1 0 :zzz: ±0 1 :x: +1

For more details on these failures, see this check.

Results for commit fbd0e879. ± Comparison against base commit f8afbfb3.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

0 files - 1 0 suites - 1 0s :stopwatch: -7s 0 tests - 1 0 :heavy_check_mark: - 1 0 :zzz: ±0 0 :x: ±0

Results for commit fbd0e879. ± Comparison against base commit f8afbfb3.

:recycle: This comment has been updated with latest results.