coderabbitai[bot]
commented
2 weeks ago Walkthrough
The changes in this pull request introduce new methods for retrieving system transactions and their results in both the Java and Kotlin SDKs. Additionally, the README files for both examples have been updated to reflect these new functionalities. The modifications include the addition of methods in the respective API connectors and interfaces, ensuring consistent error handling and response processing. Furthermore, corresponding tests have been added to validate the new functionalities, enhancing the overall coverage of the SDK.
Changes
| File | Change Summary |
|---|---|
| java-example/README.md | Added descriptions for "Get system transaction" and "Get system transaction result" in "Examples summary". |
| kotlin-example/README.md | Added descriptions for "Get system transaction" and "Get system transaction result" in "Get Transactions". |
| java-example/src/main/java/org/onflow/examples/java/getTransaction/GetTransactionAccessAPIConnector.java | Added methods: getSystemTransaction(FlowId blockId) and getSystemTransactionResult(FlowId blockId). |
| kotlin-example/src/main/kotlin/org/onflow/examples/kotlin/getTransaction/GetTransactionAccessAPIConnector.kt | Added methods: getSystemTransaction(blockId: FlowId): FlowTransaction and getSystemTransactionResult(blockId: FlowId): FlowTransactionResult. |
| sdk/src/main/kotlin/org/onflow/flow/sdk/AsyncFlowAccessApi.kt | Added methods: fun getSystemTransaction(blockId: FlowId) and fun getSystemTransactionResult(blockId: FlowId). |
| sdk/src/main/kotlin/org/onflow/flow/sdk/FlowAccessApi.kt | Added methods: fun getSystemTransaction(blockId: FlowId) and fun getSystemTransactionResult(blockId: FlowId). Marked getAccountByAddress as deprecated. |
| sdk/src/main/kotlin/org/onflow/flow/sdk/impl/AsyncFlowAccessApiImpl.kt | Added methods: override fun getSystemTransaction(blockId: FlowId) and override fun getSystemTransactionResult(blockId: FlowId). |
| sdk/src/main/kotlin/org/onflow/flow/sdk/impl/FlowAccessApiImpl.kt | Added methods: override fun getSystemTransaction(blockId: FlowId) and override fun getSystemTransactionResult(blockId: FlowId). Marked getAccountByAddress as deprecated. |
| sdk/src/test/kotlin/org/onflow/flow/sdk/FlowAccessApiTest.kt | Added tests for getSystemTransaction and getSystemTransactionResult methods. |
| sdk/src/test/kotlin/org/onflow/flow/sdk/impl/AsyncFlowAccessApiImplTest.kt | Added tests for getSystemTransaction and getSystemTransactionResult methods. |
| sdk/src/test/kotlin/org/onflow/flow/sdk/impl/FlowAccessApiImplTest.kt | Added tests for getSystemTransaction and getSystemTransactionResult methods. |
Assessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
| Add GetSystemTransaction and GetSystemTransactionResult endpoints (124) | ✅ |
Possibly related PRs
- #55: Related to the addition of new functionality descriptions in the README, enhancing usability.
- #63: Aggregates changes that include new methods for retrieving transactions, documented in the README updates.
- #80: Adds examples for getting blocks, related to the README updates regarding retrieving blocks.
- #88: Introduces functionality for getting collections, complementing the README updates.
- #105: Documentation updates for execution data and streaming examples relevant to the main PR.
- #116: Updates to the
FlowTransactionResulttype may require corresponding documentation updates. - #135: Enhances functionality in Access API methods, likely documented in the README updates.
Suggested reviewers
- jribbink
🐰 "In the code where the transactions flow,
New methods sprout, like carrots grow.
From Java to Kotlin, the changes are clear,
With examples now shining, let’s give a cheer!
For every transaction, we’ll fetch with delight,
In our SDK garden, everything feels right!" 🌱
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
github-actions[bot]
Closes: #124
Description
getSystemTransactionandgetSystemTransactionResultAccess API methods are not currently exposed by the Flow emulatorFor contributor use:
masterbranchFiles changedin the Github PR explorerSummary by CodeRabbit
Release Notes
New Features
Bug Fixes
getAccountByAddressmethod as deprecated, suggesting the use ofgetAccountAtLatestBlockinstead.Tests
getSystemTransactionandgetSystemTransactionResultmethods to ensure proper functionality and response handling.