Closed lealobanov closed 2 months ago
[!CAUTION]
Review failed
The pull request is closed.
The changes encompass a comprehensive restructuring and enhancement of the README files for the Java and Kotlin SDK examples. Titles have been updated to reflect a broader scope, and introductions have been clarified regarding the SDK's purpose. Detailed usage instructions have been added, along with a new section summarizing available examples. Additionally, a code refactor in the Kotlin example streamlines a function's implementation without altering its functionality.
File Path | Change Summary |
---|---|
java-example/README.md | Title updated to "Java Examples." Introduction revised for clarity on SDK usage and Flow Emulator. Detailed usage instructions added. New "Examples summary" section created. |
kotlin-example/README.md | Title changed to "Kotlin Examples." Introduction rewritten for clarity on SDK usage and Flow Emulator. Detailed usage instructions added. New "Examples summary" section created. |
kotlin-example/src/main/kotlin/.../GetEventAccessAPIConnector.kt | Refactored getTransactionResult function for conciseness by integrating response handling within the when expression. |
sdk/README.md | Section header changed to "Code examples." Clarified installation requirements for Flow CLI and added notes on Cadence 1.0 configuration. Updated references for example tests. |
sequenceDiagram
participant User
participant FlowCLI
participant FlowEmulator
participant AccessAPI
User->>FlowCLI: Start Emulator
FlowCLI->>FlowEmulator: Initialize
User->>FlowCLI: Run Example
FlowCLI->>AccessAPI: Get Transaction Result
AccessAPI-->>FlowCLI: Return Result
FlowCLI-->>User: Display Result
🐰 "In the meadow, changes bloom,
With examples bright, there's more room!
Java and Kotlin, side by side,
New paths to explore, come take a ride!
With clearer guides, hop along,
In this SDK world, you can't go wrong!" 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
53 files ±0 53 suites ±0 8s :stopwatch: -15s 310 tests ±0 307 :heavy_check_mark: - 3 0 :zzz: ±0 3 :x: +3
For more details on these failures, see this check.
Results for commit cefe072b. ± Comparison against base commit 52724b03.
:recycle: This comment has been updated with latest results.
0 files ±0 0 suites ±0 0s :stopwatch: ±0s 0 tests ±0 0 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit b4df69c7. ± Comparison against base commit b4df69c7.
:recycle: This comment has been updated with latest results.
26 files 26 suites 5m 4s :stopwatch: 59 tests 58 :heavy_check_mark: 0 :zzz: 1 :x:
For more details on these failures, see this check.
Results for commit 4684515d.
:recycle: This comment has been updated with latest results.
1 files +1 1 suites +1 7s :stopwatch: +7s 1 tests +1 1 :heavy_check_mark: +1 0 :zzz: ±0 0 :x: ±0
Results for commit e35a8827. ± Comparison against base commit 703ae4a8.
:recycle: This comment has been updated with latest results.
Description
Update READMEs for Kotlin and Java examples.
To-do: Let's add a section below called 'Unsupported features'. We can summarize the missing support for Websockets and Event streaming APIs for now.
For contributor use:
master
branchFiles changed
in the Github PR explorerSummary by CodeRabbit
New Features
Bug Fixes
Documentation