search

onflow / flow-nft

The non-fungible token standard on the Flow blockchain
https://onflow.org
The Unlicense
465 stars 169 forks source link

`UniversalCollection` and `BasicNFT` Contracts #208

Open joshuahannan opened 8 months ago

joshuahannan commented 8 months ago

Description

Adds the UniversalCollection contract, a contract that allows anyone to use its generic collection as their project's collection without having to define their own. This is only meant to be used by projects who don't do anything different with their collection.

This will be merged and deployed after the Cadence 1.0 upgrade is complete

turbolent commented 2 months ago

What's the status of this?

joshuahannan commented 2 months ago

@turbolent It is on hold right now while we wrap up some technical debt. Also, flowty and find were working on UniversalCollection contracts, so we need to review those soon to give them feedback and see how we might be able to potentially collaborate on them

bjartek commented 2 months ago

I looked at this yesterday.

https://github.com/bjartek/simple-flow-nft

There are some issues with composing interfaces that prohibits very terse code.

I belive Austins stab at this is way more refined.

Regards Bjarte

Bjarte Stien Karlsen Lofthusveien 77, 4760 Lillesand

On Mon, 23 Sep 2024 at 19:39, Joshua Hannan @.***> wrote:

@turbolent https://github.com/turbolent It is on hold right now while we wrap up some technical debt. Also, flowty and find were working on UniversalCollection contracts, so we need to review those https://github.com/onflow/dx-internal/issues/2 soon to give them feedback and see how we might be able to potentially collaborate on them

— Reply to this email directly, view it on GitHub https://github.com/onflow/flow-nft/pull/208#issuecomment-2368941206, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACS7NLRBYDA43MANKRVJTZYBG3TAVCNFSM6AAAAABFLSHS2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRYHE2DCMRQGY . You are receiving this because you commented.Message ID: @.***>