onflow / flow-nft

The non-fungible token standard on the Flow blockchain
https://onflow.org
The Unlicense
464 stars 166 forks source link

Add EVMBridgedMetadata view implementation #214

Closed sisyphusSmiling closed 2 months ago

sisyphusSmiling commented 2 months ago

Related: #213

Description

Adds implementation of EVMBridgedMetadata for both contract and token-level metadata.

Note: go tests pass, but I'm not able to get MetadataViews to update in the Cadence test suite to test against. I believe this is because the contract is included in those deployed to the test environment's service account and I'm not able to run an update on service account contracts in the current release version of Flow CLI. This feature is enabled in current pre-release versions of CLI and should be possible for the v2 branch until the MetadataViews contract is updated in the test suite's auto-deployed contracts.


For contributor use:

sisyphusSmiling commented 2 months ago

Thanks for the tip @joshuahannan! I did exactly that and made relevant changes to test coverage and looks like CI is passing now