search

onflow / flowkit

Apache License 2.0
7 stars 10 forks source link

Update to Cadence 1.0 #1

Closed ianthpun closed 4 months ago

codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 6.89655% with 27 lines in your changes missing coverage. Please review.

Project coverage is 43.83%. Comparing base (39af92e) to head (07f28c9).

Files Patch % Lines
tests/resources.go 0.00% 12 Missing :warning:
gateway/grpc.go 0.00% 11 Missing :warning:
config/contract.go 0.00% 1 Missing :warning:
gateway/mocks/gateway_mock.go 0.00% 1 Missing :warning:
mocks/services_mock.go 0.00% 1 Missing :warning:
transactions/transaction.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1 +/- ## =========================================== - Coverage 58.81% 43.83% -14.98% =========================================== Files 29 40 +11 Lines 2190 3365 +1175 =========================================== + Hits 1288 1475 +187 - Misses 717 1630 +913 - Partials 185 260 +75 ``` | [Flag](https://app.codecov.io/gh/onflow/flowkit/pull/1/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/onflow/flowkit/pull/1/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | `43.83% <6.89%> (-14.98%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chasefleming commented 5 months ago

Are we ready to merge in stable cadence to flowkit? Will this stop us releasing off of main?

ianthpun commented 5 months ago

@chasefleming if we merge it now, there cannot be any more chnages in the old version of flowkit (version 1.X). I think it might be safer to keep this running until we're confident enough to start a cutoff on 1.X