onflow / flowkit

Apache License 2.0
6 stars 10 forks source link

Fix `feature/stable-cadence` tests & `main` branch CI trigger #19

Closed jribbink closed 6 months ago

jribbink commented 6 months ago

Looks like tests are failing from https://github.com/onflow/flowkit/pull/18.

CI didn't trigger because branch was initially targetting main, but CI doesn't trigger for main πŸ™ƒ

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (feature/stable-cadence@433a6c5). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/stable-cadence #19 +/- ## ========================================================= Coverage ? 58.62% ========================================================= Files ? 29 Lines ? 2202 Branches ? 0 ========================================================= Hits ? 1291 Misses ? 725 Partials ? 186 ``` | [Flag](https://app.codecov.io/gh/onflow/flowkit/pull/19/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | Coverage Ξ” | | |---|---|---| | [unittests](https://app.codecov.io/gh/onflow/flowkit/pull/19/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | `58.62% <ΓΈ> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.