search

onflow / flowkit

Apache License 2.0
6 stars 10 forks source link

fix issue with overridden default options #46

Closed ianthpun closed 3 months ago

ianthpun commented 3 months ago

updated the options call so that it adds the default first, then adds the options after so the default doesnt override the incoming options (prepend vs append)

ianthpun commented 3 months ago

@turbolent Im trying to see if its possible, but i think we're going to have the same issue as I've outlined here

https://github.com/onflow/flow-go-sdk/pull/636/files#diff-04c09091a8863f8893734eb49df86d6f6e59ff92255cbe7461f3107d7d6e8d39R67-R80

We can confirm that the length is the same, but due to how function signatures are compared, I haven't been able to figure out how to compare functions being called here. I think the most ideal solution would be to see all dialOptions set and just compare the output there. Let me think about this for a little bit

ianthpun commented 3 months ago

Really culdnt find a way to test this unfortunately