search

onflow / flowkit

Apache License 2.0
6 stars 10 forks source link

Allow for private key to be created in a target directory #48

Closed chasefleming closed 3 months ago

chasefleming commented 3 months ago

Closes: #47

chasefleming commented 3 months ago

@bjartek this is a minor breaking change. Will this be an issue upgrading for you? Alternative would be we could have the existing Init function and a new function called InitFromDirectory.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 58.81%. Comparing base (200347d) to head (32f9589). Report is 1 commits behind head on main.

Files Patch % Lines
accounts/account.go 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #48 +/- ## ========================================== + Coverage 58.77% 58.81% +0.03% ========================================== Files 29 29 Lines 2193 2190 -3 ========================================== - Hits 1289 1288 -1 + Misses 718 717 -1 + Partials 186 185 -1 ``` | [Flag](https://app.codecov.io/gh/onflow/flowkit/pull/48/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/onflow/flowkit/pull/48/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | `58.81% <20.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bjartek commented 3 months ago

@bjartek this is a minor breaking change. Will this be an issue upgrading for you? Alternative would be we could have the existing Init function and a new function called InitFromDirectory.

Not an issue for me