feat: added ctx support to all methods that require it and fixed tests

onflow / flowkit

Apache License 2.0

7 stars 10 forks source link

feat: added ctx support to all methods that require it and fixed tests #5

Closed bjartek closed 8 months ago

bjartek commented 8 months ago

fixes #4

turbolent commented 8 months ago

@bjartek Did you mean to target master? Changes to the feature branch should be related to it (Cadence 1.0) upgrades. The feature branch gets synced with / gets changes from master regularly.

bjartek commented 8 months ago

I was told by Ian to target this branch since it breaks bc, but this feature would be very nice to have in v1 of flowkit aswell.

Is the small breaking change to Ping ok, or should we just hardcode the context in Ping for now to not break bc?

bjartek commented 8 months ago

@turbolent i created an alternate pr #9 that targets master and do not break BC in the main Services interface.